Attention is currently required from: jolly, laforge. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email )
Change subject: V1.2: Add function to set Device Capabilities ...................................................................... Patch Set 7: Code-Review+1 (3 comments) File src/ipa/libipa/euicc.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/62e9d00a_b996fd7c?usp=email : PS7, Line 535: /* Capabilities according to 3GPP TS 102.221, section 11.1.19.2.4 and GSMA SGP.32, section 3.8.2 */ Maybe we should also add GSMA SGP.22, section 3.4.2. In ipad.h you refer to this spec. File src/ipa/main.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/3779a63d_54d0ad06?usp=email : PS7, Line 72: printf(" -D 0xXX ..................... set SGP.22 device capabilities other than the 3 that are required by this IPAd\n"); maybe point directly to the table like: set optional device capabilities (SGP.22, table 7, b8-b4) ? https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/5b299a08_04280cc6?usp=email : PS7, Line 288: printf(" device_capabilities = %u\n", cfg.device_capabilities); Maybe use %02x because it is a bitmask? -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c Gerrit-Change-Number: 43060 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 15:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
