pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/43265?usp=email )
Change subject: tests/sms: Validate gsm_septet_pack2() succeeds
......................................................................
tests/sms: Validate gsm_septet_pack2() succeeds
Related: Coverity CID#562694
Change-Id: I12583ce07e7885974225ce0118f737c4a5f9bcfd
---
M tests/sms/sms_test.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
osmith: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c
index dda3c56..d9c1c8f 100644
--- a/tests/sms/sms_test.c
+++ b/tests/sms/sms_test.c
@@ -381,6 +381,7 @@
/* In our case: test_multiple_decode[0].ud_hdr_ind equals number of
padding bits*/
octet_length = gsm_septet_pack2(coded, sizeof(coded), tmp,
concatenated_part1_septet_length, test_multiple_encode[0].ud_hdr_ind);
+ OSMO_ASSERT(octet_length == 134);
/* copy header */
memset(tmp, 0x42, sizeof(tmp));
@@ -399,6 +400,7 @@
/* In our case: test_multiple_decode[1].ud_hdr_ind equals number of
padding bits*/
octet_length = gsm_septet_pack2(coded, sizeof(coded), tmp,
concatenated_part2_septet_length, test_multiple_encode[1].ud_hdr_ind);
+ OSMO_ASSERT(octet_length == 36);
/* copy header */
memset(tmp, 0x42, sizeof(tmp));
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43265?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I12583ce07e7885974225ce0118f737c4a5f9bcfd
Gerrit-Change-Number: 43265
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
