Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43349?usp=email )
Change subject: sua: sua_parse_gt(): reject GT with num_digits exceeding blob length ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/sua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43349/comment/ea9df4ab_feb7201b?usp=email : PS1, Line 417: /* Parse as much as we can; return -EINVAL */ I wonder what's the point in parsing as much as we can if anyway we end up in error, but ok...To me working on known malfunctioned packets doesn't seem like a good idea. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I918278b6471bc78511bf97a292204e6719d4031a Gerrit-Change-Number: 43349 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 20 Aug 2026 16:04:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
