Attention is currently required from: neels.

laforge has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/43287?usp=email )

Change subject: saip BatchPersonalization: call rebuild_mandatory_services()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
I don't see how we'd ever need to rebuild the mandatory service list on a _per 
profile_ basis.  Shouldn't that be modified once and be identical for all of 
the profiles in one personalization job?  It's not like we can have 10 profiles 
with different mandatory services in one job?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43287?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5e6eef0f1845a25cddb03af8d16c40e305bcdc1f
Gerrit-Change-Number: 43287
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Sat, 22 Aug 2026 08:05:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to