Attention is currently required from: fixeria, lynxis lazus, osmith.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email )

Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on 
re-Attach
......................................................................


Patch Set 3:

(1 comment)

File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/42594/comment/e21dfaf0_856b01fa?usp=email
 :
PS3, Line 1348:                                 sgsn_pdp_ctx_terminate(pdp);
calling
sgsn_pdp_ctx_terminate() may have the problem that if "pdp->ggsn" is false, the 
pdp is not freed. See sgsn_pdp_ctx_terminate() vs
process_ms_ctx_status().



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1
Gerrit-Change-Number: 42594
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: lynxis lazus <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Mon, 24 Aug 2026 15:42:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to