pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43398?usp=email )


Change subject: xua_asp_fsm: ASP ACT: Avoid double lookup of Traffic Mode Type 
IE
......................................................................

xua_asp_fsm: ASP ACT: Avoid double lookup of Traffic Mode Type IE

Change-Id: Idc764d9d6f517cd28defaf226e6b0957cce92585
---
M src/xua_asp_fsm.c
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran 
refs/changes/98/43398/1

diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 679533b..62bc932 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -640,6 +640,7 @@
        struct osmo_ss7_as *as;
        struct ss7_as_asp_assoc *assoc;
        struct xua_msg_part *asp_id_ie;
+       struct xua_msg_part *traf_mode_ie;
        struct xua_msg *xua_in;
        uint32_t traf_mode = 0;
        struct xua_msg_part *rctx_ie;
@@ -689,8 +690,8 @@
        case XUA_ASP_E_ASPTM_ASPAC:
                xua_in = data;
                ENSURE_SG_OR_IPSP(fi, event);
-               if (xua_msg_find_tag(xua_in, M3UA_IEI_TRAF_MODE_TYP)) {
-                       traf_mode = xua_msg_get_u32(xua_in, 
M3UA_IEI_TRAF_MODE_TYP);
+               if ((traf_mode_ie = xua_msg_find_tag(xua_in, 
M3UA_IEI_TRAF_MODE_TYP))) {
+                       traf_mode = xua_msg_part_get_u32(traf_mode_ie);
                        if (traf_mode != M3UA_TMOD_OVERRIDE &&
                            traf_mode != M3UA_TMOD_LOADSHARE &&
                            traf_mode != M3UA_TMOD_BCAST) {

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43398?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Idc764d9d6f517cd28defaf226e6b0957cce92585
Gerrit-Change-Number: 43398
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>

Reply via email to