Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email )
Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Given current state of osmo-sgsn I'd say this patch deserves an existing TTCN-3 test covering the scenario it fixes, specially given current complexity of tearing down stuff in there. And yes, I know you added a unit test crafting the mmctx manually and so on, but that's not useful enough given the code base imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Gerrit-Change-Number: 42594 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: lynxis lazus <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 08:02:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
