Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email )
Change subject: xua_msg: return M3UA_ERR in xua_dialect_check_all_ies() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/xua_msg.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389/comment/c1040eae_5fb4be6c?usp=email : PS2, Line 549: return 0; Yes, this would be for a different commit. Just pointed out that this might be a problem with returning 0 "success" for unknown class. > BTW, if we return here anyway the code flow will reject the message a few > lines afterwards at the caller when it checks the msg_class/msg_type and > finds an unknown one. True, I didn't realize that both callers of this function check it right afterwards. So it is fine here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9df00f9b10f7341171912cf32e8ba57344ae8b4a Gerrit-Change-Number: 43389 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 08:03:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
