Patch Set 1:

> I support the idea of using a proper enum X instead of int.
 > 
 > But do we really have to move these enums away from classes?
 > I believe there should be a way to avoid this...

I'm open to advises on how to accomplish it using another method ;)

Again, I have the issue in which I cannot include classes into vty.h for 2 
reasons:
- trx_vty is in CommonLibs, which is used by Transceiver52, and not the other 
way. I'm not really sure if it really makes sense to have those separated in 
different directories and built in 2 stages actually. We could move everything 
to be build togetether and drop this issue.
- trx_vty is C which cannot then include c++ headers. I could try to compile it 
as C++, but not sure neither if I want to go that direction or the opposite 
(slowly pushing c++ back to only required parts and add C shims for it).

-- 
To view, visit https://gerrit.osmocom.org/6649
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5b0576aa96869756f1629a40306c0043b6304b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-HasComments: No

Reply via email to