laforge has submitted this change. (
https://gerrit.osmocom.org/c/onomondo-ipa/+/43064?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
)Change subject: V1.2: Remove error code from ListEimResult
......................................................................
V1.2: Remove error code from ListEimResult
Remove the commandError code from listEimError in ListEimResult. The
IPA process must use undefinedError instead.
Reference: SGP.23 Section 2.11.2.1
Related: SYS#8101
Change-Id: I8acb868970a589e70c1688427994854f9393a01b
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/ListEimResult.h
M src/ipa/libipa/es10b_load_euicc_pkg.c
3 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
dexter: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/asn1/SGP32Definitions.asn b/asn1/SGP32Definitions.asn
index 4c43eef..4fbda2a 100644
--- a/asn1/SGP32Definitions.asn
+++ b/asn1/SGP32Definitions.asn
@@ -294,7 +294,6 @@
ListEimResult ::= CHOICE {
eimIdList SEQUENCE OF EimIdInfo,
listEimError INTEGER {
- commandError(7),
undefinedError(127)
}
}
diff --git a/src/ipa/libasn/ListEimResult.h b/src/ipa/libasn/ListEimResult.h
index 546a7c3..6dbf3ee 100644
--- a/src/ipa/libasn/ListEimResult.h
+++ b/src/ipa/libasn/ListEimResult.h
@@ -30,7 +30,6 @@
} ListEimResult_PR;
typedef enum ListEimResult__listEimError {
- ListEimResult__listEimError_commandError = 7,
ListEimResult__listEimError_undefinedError = 127
} e_ListEimResult__listEimError;
diff --git a/src/ipa/libipa/es10b_load_euicc_pkg.c
b/src/ipa/libipa/es10b_load_euicc_pkg.c
index 51963eb..7e20d5e 100644
--- a/src/ipa/libipa/es10b_load_euicc_pkg.c
+++ b/src/ipa/libipa/es10b_load_euicc_pkg.c
@@ -553,7 +553,7 @@
eim_cfg_data = ipa_es10b_get_eim_cfg_data(ctx);
if (!eim_cfg_data) {
euicc_result_data->choice.listEimResult.present =
ListEimResult_PR_listEimError;
- euicc_result_data->choice.listEimResult.choice.listEimError =
ListEimResult__listEimError_commandError;
+ euicc_result_data->choice.listEimResult.choice.listEimError =
ListEimResult__listEimError_undefinedError;
} else {
euicc_result_data->choice.listEimResult.present =
ListEimResult_PR_eimIdList;
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43064?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I8acb868970a589e70c1688427994854f9393a01b
Gerrit-Change-Number: 43064
Gerrit-PatchSet: 13
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
