Attention is currently required from: dexter.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/43402?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: rest_api_response_schema: re-structure REST API responses
......................................................................
rest_api_response_schema: re-structure REST API responses
The REST API responses are in parts inconsistent and the schema
file lacks proper spec references in the description fields. Also
in some places we mix proprietary error codes with return codes
from SGP.32, which may lead to unexpected effects in case the SGP.32
ASN.1 spec changes.
With this patch we clean up those remaining shortcomings, in
particular the following:
- Add a spec reference to each non-proprietary field
- No longer mix SGP.32 error codes with proprietary error codes
- Rename procedureError to eimProcedureError and make sure all
possible error codes appear in the JSON schema properly.
- Add dedicated error fields for each SGP.32 error code, so that
the REST API user gets more detailed information in the error case
- Restructure profileInstallationResult also return AID and
SimaResponse, also add an profileInstallationError field which
returns BppCommandId, ErrorReason and SimaResponse so that a REST
API user has a chance to debug profile installation issues.
- Orient the layout of result and error responses closer to the
SGP.32 ASN.1 specification.
- Do not specify the error codes in the JSON schema file to avoid
unexpected problems when SGP.32 adds new error code. A spec
reference in the field description should be sufficient.
Change-Id: I16cc063c185727e1b30f26d656bd15154504b087
Related: SYS#8100
---
M doc/build.md
M doc/database.md
M priv/rest_api_response_schema.json
M src/esipa_asn1_handler.erl
M src/esipa_asn1_handler_utils.erl
M src/esipa_asn1_http_handler.erl
M src/esipa_json_handler.erl
M src/esipa_json_http_handler.erl
M src/esipa_rest_utils.erl
M src/mnesia_db.erl
M src/mnesia_db_euicc.erl
M src/mnesia_db_rest.erl
M src/mnesia_db_work.erl
13 files changed, 388 insertions(+), 456 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/02/43402/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43402?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I16cc063c185727e1b30f26d656bd15154504b087
Gerrit-Change-Number: 43402
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter <[email protected]>
