Patch Set 1:

(1 comment)
File src/vty/fsm_vty.c:

Line 192:       if (!osmo_fsm_vty_cmds_installed) {
what we normally do is 

if (osmo_fsm_vty_cmds_installed)

to avoid having to indent all of the other statements in the function body and 
loose horizontal screen real-estate.

Also, if we go for this pattern, there are many other instances where the vty 
commands are installed from libraries.

One might even hide the logic inside install_element itse?lf? not sure.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I10b0b1c1c1bf44c3b8eafc465c1ee06ea2590682
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to