Patch Set 5:

> > I don't think any of our vty has "on|off" so far. We have a
 > > enable/disable or 0/1 ,(or cmd / no cmd). Let's not introduce
 > even
 > > more inconsistencies, please.
 > 
 > We have on/off for osmux for instance. 

*sigh*.  Not sure how that slipped through the cracks at the time.  I really 
dislike
those inconsistencies.  They are a public sign of how sloppy we are :/

> But I can change it to other stuff if looks better to you, I have no 
> preference.

I think any method is better than the on|off

-- 
To view, visit https://gerrit.osmocom.org/6650
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie084c1b30b63f91c6e7640832ec1797d9e813832
Gerrit-PatchSet: 5
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-HasComments: No

Reply via email to