Patch Set 5:

> Unless it's a lot of effort to support both ways, I would prefer to
 > have one release that supports both,
 > but will print related warnings during start-up if the legacy
 > command line arguments are used, and then
 > remove it in the next release.  This gives people some time.  Also,
 > it would open the possibility to
 > * start with command line arguments
 > * do "write file" to generate a config file from those old settings
 > 

Ok, I'll try to modify this commit to use parameters to fill the trx_ctx 
structure and print a warning if any of the parameters is passed.

We still require to find a .cfg file in the path or through (-C), I guess 
that's fine.

On next release we can then drop the parameters and link -c to -C to read the 
config file (since -c is currently used for other purposes, and all osmo-* use 
-c to rad the config file).

 > Also, before we make any related release, we have to make sure all
 > documentation is updated, from wiki to
 > user manuals, ...

Agree.

 > 
 > > It may make sense to make a release before 6618 (depend on
 > > libosmocore), and then merge everything at once.
 > 
 > I guess that means reverting the change in master and applying all
 > related patches to branch (via gerrit) first.

To make things easier, maybe it's a good idea to release in the current state, 
that's it having a new dependency libosmocore but without affecting the current 
use of osmo-trx.

-- 
To view, visit https://gerrit.osmocom.org/6651
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8de1a5da4b3c0b6a49e00033f616e1d66656adf
Gerrit-PatchSet: 5
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-HasComments: No

Reply via email to