Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/6860/1/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:

Line 463:       
rate_ctr_inc(&msc->network->bsc_ctrs->ctr[BSC_CTR_PAGING_ATTEMPTED]);
it's called PAGING_ATTEMPTED and we should only increment it if we actually 
have attempted paging.  If mandatory IEs ar emissing (see below), we didn't 
attempt anything.

Moving it just above the "switch (cell_ident)" makes sense.  There's still some 
code paths below where we might fail before attempting to page, but I guess 
this location is a good compromise: Keep counter incremenet in shared code (and 
thus only called once) but avoid increments in the most obvious error paths.


-- 
To view, visit https://gerrit.osmocom.org/6860
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3eb6724bc655806c3ce3c28448069590d99f91
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to