Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/6911/1/contrib/jenkins.sh File contrib/jenkins.sh: Line 86: if [ -z "${INSIDE_CHROOT}" ]; then I think this should always be executed, with no condition. Otherwise in the case in which we call us recursively, the workspace won't be cleaned after finishing (since this condition won't be true and exit 0 is called after the recursive call in line 59. -- To view, visit https://gerrit.osmocom.org/6911 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib228ff247a72b21b12e8dd4cbe3afe3e858c89d3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
