Patch Set 2: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/6913/2/src/osmo_ms_driver/simple_loop.py File src/osmo_ms_driver/simple_loop.py: Line 41: You could add extra checking for the maximum len of 107 chars, in case it is truncated at somedirectory level it will fail to be created. We already experienced this and was an annoying bug. Have a look at bts_osmo.py:44: if len(self.pcu_socket_path().encode()) > 107: raise log.Error('Path for pcu socket is longer than max allowed len for unix socket path (107):', self.pcu_socket_path()) -- To view, visit https://gerrit.osmocom.org/6913 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea06f33870cab9f21e9a1a1feb9758467343dd29 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
