Patch Set 3: Overall it looks fine as a first working step, but I'd like seeing all this a lot better integrated with current osmo-gsm-tester, so that you can re-use more stuff which might be useful (testsuites, test, junit output, configuration of resources, etc.) and we can also re-use later in the future some stuff you are adding (using mobible app as ms, virtphy, etc). I understand that you are not familiar with all this specific osmo-gsm-tester parts, and some require some good amount of work, so we can merge it in a separate dir as it is now and work on it later.
What I envision is to have all this fully integrated at some point: * mobile "app" + lua script + unix socket being an implementation of the Modem class (which we currently implement using ofono, but use the same API to be able to share tests). * Have a OsmoBTSVirtphy implementation (bts_osmo_virtphy.py) the same way we have other osmo-bts implementations. * To be able to handle both virt arfcn and real arfcn, we should add a property to arfcn resources to be able to disntiguish those for tests (and add it to the logic when implementing arfcn resources correctly, see https://osmocom.org/issues/2230). * Improve our current loop to use passive polling for all the things which can be used this way (some still require active polling with a timeout, we can just add a timerfd for it or some specific implementation to handle a list of timers). * Move most of the stuff in __main__ in this commit to a test in suites/suite_foobar/test_foobar.py and run it together with other currnet tests. -- To view, visit https://gerrit.osmocom.org/6919 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58c938500a067eebb213750e56d8bf4d8af43df2 Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: No
