Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/6982/1/include/osmo-bts/pcuif_proto.h File include/osmo-bts/pcuif_proto.h: Line 65: uint32_t fn; it might be useful to state which fiels are expected to be populted in which case. By simply adding those definitions to bsc/bts/pcu code and not using them, we're not really updating the interface version, are we? Which of those are needed to be populated by which of the programs? -- To view, visit https://gerrit.osmocom.org/6982 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d330aca26249ee94ece5e415079f0b75c6e8b48 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
