Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/7059/1/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

Line 3683:              return GSM48_REJECT_PROTOCOL_ERROR;
> remember, this is the cause value as sent back to the MS.
yeah, I tried to make sense of 24.008 annex G but it's quite open for 
interpretation.

>From the fact that the MS sending a wrong SRES leads to Illegal MS, I thought 
>that sending A5 capabilites not compatible with the network might also qualify 
>as Illegal MS; as in, something about your crypto is wrong, you're illegal ... 
>?

Then I thought, the MS contacting with the wrong protocol (RAN) would be a 
Protocol Error; that's highly unlikely to happen anyway and actually you're 
right that Network Failure is a better fit here.


-- 
To view, visit https://gerrit.osmocom.org/7059
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4db77fea1a4bcd161218582126a5d83ca171f7cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to