Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/6994

to look at the new patch set (#4).

bsc_vty: display bts features in show bts

The command show bts displays all kind of BTS related info, but it
does not display the bts features yet.

- display bts specific features in vty-command show bts

Change-Id: I650133563436349d4ce55f292ea683dbb2ae68d7
---
M src/libbsc/bsc_vty.c
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/6994/4

diff --git a/src/libbsc/bsc_vty.c b/src/libbsc/bsc_vty.c
index be2e559..d0bfbcf 100644
--- a/src/libbsc/bsc_vty.c
+++ b/src/libbsc/bsc_vty.c
@@ -288,6 +288,24 @@
                vty_out(vty, " (%d)", count);
 }
 
+static void bts_dump_vty_features(struct vty *vty, struct gsm_bts *bts)
+{
+       unsigned int i;
+       bool no_features = true;
+       vty_out(vty, "  Features:%s", VTY_NEWLINE);
+
+       for (i = 0; i < _NUM_BTS_FEAT; i++) {
+               if (osmo_bts_has_feature(&bts->features, i)) {
+                       vty_out(vty, "    %03u ", i);
+                       vty_out(vty, "%-40s%s", osmo_bts_feature_name(i), 
VTY_NEWLINE);
+                       no_features = false;
+               }
+       }
+
+       if (no_features)
+               vty_out(vty, "    (not available)%s", VTY_NEWLINE);
+}
+
 static void bts_dump_vty(struct vty *vty, struct gsm_bts *bts)
 {
        struct pchan_load pl;
@@ -461,6 +479,8 @@
                bts->bts_ctrs->ctr[BTS_CTR_BTS_OML_FAIL].current,
                bts->bts_ctrs->ctr[BTS_CTR_BTS_RSL_FAIL].current,
                VTY_NEWLINE);
+
+       bts_dump_vty_features(vty, bts);
 }
 
 DEFUN(show_bts, show_bts_cmd, "show bts [<0-255>]",

-- 
To view, visit https://gerrit.osmocom.org/6994
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I650133563436349d4ce55f292ea683dbb2ae68d7
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder

Reply via email to