Patch Set 5: -Code-Review (1 comment)
https://gerrit.osmocom.org/#/c/6667/4/src/libbsc/abis_nm.c File src/libbsc/abis_nm.c: Line 2851: void abis_nm_ipaccess_cgi(uint8_t *buf, struct gsm_bts *bts) hmm, looking at this again, I don't actually like this part anymore: passing a gsm48_ra_id* to this function, but it actually writes one byte past sizeof(gsm48_ra_id). So I'll change it to keep the uint8_t* arg, but can internally use a gsm48_ra_id*. -- To view, visit https://gerrit.osmocom.org/6667 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d3908fb8ca1e2e669d257b5d59b40675fa85d06 Gerrit-PatchSet: 5 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
