Patch Set 2: Why are we adding more tests like this with hardcoded byte arrays that no human will ever understand again while reading the code? What's the rationale? Unit tests are nice for testing simple functions. But if you're testing external protocols, why not use ttcn3? It's not a rhetorical question
-- To view, visit https://gerrit.osmocom.org/7058 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba56556207cf6e79e6531b0e7dd3eaec28fb5eaa Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
