Patch Set 4: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/7021/4/jobs/osmo-gsm-tester.yml File jobs/osmo-gsm-tester.yml: Line 127: project: '{repo}' where is the {repo} coming from? IIUC the '- project:' section responsible for these jobs doesn't define repos. Is it somehow re-using the repo definition from above? If not, I'd also prefer this in its own file. Actually I prefer it in its own file in any case. Line 132: # all artifact in one place ("artifacts") -- To view, visit https://gerrit.osmocom.org/7021 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0 Gerrit-PatchSet: 4 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-HasComments: Yes
