Patch Set 5: Code-Review-1

Thanks for moving the tests to the existing test system. It seems however the 
new test is not being run in jenkins. Running it locally (make check) in my PC 
actually shows it's missing exec permission on the file (I don't know why 
jenkins doesn't fail). you need to +x it.

Also, I had to apply the following changes locally to have it working, please 
add them and re-submit. Once you have it working, also run:
cd selftest && ./cdf_test.py > cdf_test.ok
To have the expected output in a file, otherwise it's not checked.

diff --git a/selftest/cdf_test.py b/selftest/cdf_test.py
old mode 100644
new mode 100755
index ec970df..7ef65f9
--- a/selftest/cdf_test.py
+++ b/selftest/cdf_test.py
@@ -1,13 +1,13 @@
+#!/usr/bin/env python3
+import _prep
 from osmo_ms_driver import cdf
 from datetime import timedelta

-
 def print_fuzzy_compare(want, expe, len=3):
     want_str = str(want)[0:len]
     expe_str = str(expe)[0:len]
     print(want_str, expe_str, want_str == expe_str)

-
 def check_steps(a, steps, fun):
     print("Done", a.is_done())
     for step in steps:
@@ -39,7 +39,6 @@ def testImmediate():
     print("Done", a.is_done())
     print_fuzzy_compare(a.current_value(), 1.0)

-
 def testLinearWithDuration():
     print("Testing linear with duration")
     a = cdf.linear_with_duration(timedelta(seconds=10), 
step_size=timedelta(seconds=2))

-- 
To view, visit https://gerrit.osmocom.org/6230
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3064f4c3c4c7af5d3491f850090516e541f4d3
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <hol...@freyther.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Holger Freyther <hol...@freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-HasComments: No

Reply via email to