Patch Set 1:

(3 comments)

In general, looks good.

Regarding to the $(top_builddir), this could be done
in a separate change...

https://gerrit.osmocom.org/#/c/7148/1/Transceiver52M/arm/Makefile.am
File Transceiver52M/arm/Makefile.am:

Line 12: libarch_la_LIBADD = ../common/libarch_common.la
Why not to use $(top_builddir) here?


https://gerrit.osmocom.org/#/c/7148/1/Transceiver52M/common/Makefile.am
File Transceiver52M/common/Makefile.am:

Line 4: libarch_common_la_LIBADD =
Probably, this var will remain empty for long time.
Do we really need this?


https://gerrit.osmocom.org/#/c/7148/1/Transceiver52M/x86/Makefile.am
File Transceiver52M/x86/Makefile.am:

Line 7: libarch_la_LIBADD = ../common/libarch_common.la
Also $(top_builddir)?


-- 
To view, visit https://gerrit.osmocom.org/7148
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81bb4251d18fce978d27849b621b20f541caab0b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to