Patch Set 1:


In general, looks good.

Regarding to the $(top_builddir), this could be done
in a separate change...
File Transceiver52M/arm/

Line 12: libarch_la_LIBADD = ../common/
Why not to use $(top_builddir) here?
File Transceiver52M/common/

Line 4: libarch_common_la_LIBADD =
Probably, this var will remain empty for long time.
Do we really need this?
File Transceiver52M/x86/

Line 7: libarch_la_LIBADD = ../common/
Also $(top_builddir)?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I81bb4251d18fce978d27849b621b20f541caab0b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <>
Gerrit-HasComments: Yes

Reply via email to