Patch Set 3: (1 comment)
https://gerrit.osmocom.org/#/c/7188/3/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: Line 978: return vlr_subscr_rx_auth_fail(conn->vsub, NULL); hmm, this is actually meant for the MM Authentication Failure message from the MS, which also is capable of triggering an UMTS AKA Auth Resync. But I guess handling it like this is nicer than passing zero RES into vlr_subscr_rx_auth_resp() below, like in an earlier patch set? What do you guys think? We could also go for a timeout, in the sense of dropping invalid messages on the floor. But here we can invalidate the conn fast. (just not conn_close() directly, which loses the responses we're meant to send in case of failure) -- To view, visit https://gerrit.osmocom.org/7188 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4179a290069ac61d0662de4ec7ca3edb76988899 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
