Harald Welte has submitted this change and it was merged.

Change subject: sysinfo.c: SI1 is optional; Send SI2 at TC=0 if no SI1 exists
......................................................................


sysinfo.c: SI1 is optional; Send SI2 at TC=0 if no SI1 exists

SI1 is only required if frequency hopping is used or if NCH is used. So it's 
optional.

If OsmoBTS has no SI1 configured, it will transmit the empty SI1 buffer
at TC=0, and as a result no valid SI will be broadcast at TC=0.

Change-Id: I41ab885c00e943199b2e939e98f30e267ecffbee
Closes: OS#3051
---
M src/common/sysinfo.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/sysinfo.c b/src/common/sysinfo.c
index cf86380..6f7a387 100644
--- a/src/common/sysinfo.c
+++ b/src/common/sysinfo.c
@@ -73,7 +73,9 @@
                 * present in a cell. If the MS finds another message
                 * when TC = 0, it can assume that System Information
                 * Type 1 is not in use.  */
-               return GSM_BTS_SI(bts, SYSINFO_TYPE_1);
+               if (GSM_BTS_HAS_SI(bts, SYSINFO_TYPE_1))
+                       return GSM_BTS_SI(bts, SYSINFO_TYPE_1);
+               return GSM_BTS_SI(bts, SYSINFO_TYPE_2);
        case 1:
                /* A SI 2 message will be sent at least every time TC = 1. */
                return GSM_BTS_SI(bts, SYSINFO_TYPE_2);

-- 
To view, visit https://gerrit.osmocom.org/7184
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41ab885c00e943199b2e939e98f30e267ecffbee
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder

Reply via email to