Patch Set 1: > At first sight I'm not entirely convinced. > > An RLL REL IND indicates release of one SAPI (on either DCCH or > SACCH), not release of the radio channel. The MS could release > SAPI3 as no SMS transmissions are pending but still keep SAPI 0 for > other signaling? > > Imagine SMS over SACCH while a call is ongoing.
Yes, I was wondering about that. Our code walks all over that by just flattening the SAPI indicator out completely. It appears this needs a proper revisit and tests to go with it. I opened https://osmocom.org/issues/3060 -- To view, visit https://gerrit.osmocom.org/7221 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f8c9c4e6b6850b15c70250fd3f88bdf75f9accf Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: No
