Patch Set 16:

(3 comments)

https://gerrit.osmocom.org/#/c/6509/16/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

Line 711:               remain -= sizeof(struct gsm48_loc_area_id) + 
sizeof(*ci_be);
and might be nice to define a local var for 

  sizeof(struct gsm48_loc_area_id) + sizeof(*ci_be)

instead of repeating over and over


Line 739:               remain -= sizeof(*lacp_be) + sizeof(*ci_be);
same repetition of sizes


Line 758:               remain -= sizeof(*ci_be);
same repetition, even if it's only one sizeof(), would be nice to formalize 
that it's the identical step size each time. Same below.


-- 
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb
Gerrit-PatchSet: 16
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to