Patch Set 16:

(2 comments)

https://gerrit.osmocom.org/#/c/6509/16/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

Line 705:               if (decode_lai(&data[lai_offset], &id->lai.plmn.mcc, 
&id->lai.plmn.mnc, &id->lai.lac) != 0)
> error here: lai_offset is unset in the first loop, and uses the value of th
Yikes! Thanks for spotting this.

(The bug was introduced while deriving this code from osmo-bts -- the osmo-bts 
code does not have this bug.)


Line 711:               remain -= sizeof(struct gsm48_loc_area_id) + 
sizeof(*ci_be);
> and might be nice to define a local var for 
Agreed. Will introduce an extra const variable in all such cases in the next 
patch set.


-- 
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb
Gerrit-PatchSet: 16
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to