Patch Set 3: Code-Review+2


this is just peanuts comments, feel free to decide yourself
File src/osmo_gsm_tester/

Line 23: class PowerSupply(log.Origin, metaclass=ABCMeta):
what's the rationale for the meta class to inherit from? It's enough to just 
have the PowerSupplySispm in loosely typed python? AFAICT the parent class 
doesn't serve any purpose. Are we planning to add more KNOWN_SUPPLY_TYPES any 
time soon? Otherwise, I guess I'd just have the Sispm and be done ==  about 
half the amount of overhead code.

Line 42:         'Turn on (onoff=True) or off (onof=False) the device'
typo "onof"
File src/osmo_gsm_tester/

Line 61:     def powered(self):
would prefer "is_powered()", or "power_get()" to match below

Line 66:         'Turn on (onoff=True) or off (onof=False) the device'

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I981c260eca1a61657147e6d83b4226618088223c
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <>
Gerrit-HasComments: Yes

Reply via email to