Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/7160/3/src/osmo_gsm_tester/bts.py
File src/osmo_gsm_tester/bts.py:

Line 26: class Bts(log.Origin, metaclass=ABCMeta):
could you explain ABCMeta? What does it help us with?


Line 45: # PUBLIC - INTERNAL API
what now, public or internal? I don't really like these huge comments, I guess 
the info should rather go in each function's doc string. Just a matter of taste.


-- 
To view, visit https://gerrit.osmocom.org/7160
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13133e61abda73a8b507c1a1bd7b98c677460f9
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to