Patch Set 3: Code-Review+1

(1 comment)

I'd say this commit is small enough to be joined with the commit that is 
actually using it.

https://gerrit.osmocom.org/#/c/7166/3/src/osmo_gsm_tester/pcu.py
File src/osmo_gsm_tester/pcu.py:

Line 51: ###################
...so many lines wasted by pointless comments. My twocents, rather put the 
information in doc strings and by adding underscores like

  class Foo():
    "Help clank Bar with Baz support"
  
     def _la():
       "one la; private, rather call lala()"
       go()

     def lala():
       "do a complete lala"
       self._la()
       self._la()

i.e. the "class PcuDummy" already tells us that it's the PcuDummy class, and 
"for BTS without proper PCU control" becomes the docstring.


-- 
To view, visit https://gerrit.osmocom.org/7166
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37ba38f7d81134e5f0ca28fa684fdb09c753bb04
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to