Patch Set 3: Code-Review+1

(1 comment)

if you must, but...

https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py
File src/osmo_gsm_tester/bts_osmo.py:

Line 80:     def ready_for_pcu(self):
from a python doc point of view, nothing has changed at all. If a function is 
considered private, it should have an underscore. Otherwise whether test 
scripts call a function or not doesn't really change semantics of the class 
definition. I think there's no point to this :)


-- 
To view, visit https://gerrit.osmocom.org/7159
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8978854404897ae5de7e3100d55d86c7a5c1df1
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to