Patch Set 4: Code-Review+1

(8 comments)

mainly good, with a few questions...

https://gerrit.osmocom.org/#/c/7168/4/src/osmo_gsm_tester/bts_nanobts.py
File src/osmo_gsm_tester/bts_nanobts.py:

Line 36:         if conf.get('addr', None) is None:
conf.get('addr') is identical to passing None explicitly


Line 40:     def configure(self):
"_configure()" if it is really supposed to be "protected"?


Line 55: ########################
<repeat previous remarks>


Line 105:         ipfind = AbisIpFind(self.suite_run, self.run_dir, iface, 
'preconf')
(do we also do this for sysmoBTS? So far we just assume the BTS is there, 
right? ah, is this to wait for power-on? then a comment to mention that would 
be nice)


Line 121:         # BTS restarting.
but abis-ip find was already up there.


Line 125:         ipfind = AbisIpFind(self.suite_run, self.run_dir, iface, 
'postconf')
another one?


Line 131:         event_loop.wait(self, self.bsc.bts_is_connected, self, 
timeout=600)
would this technically be enough without the sleep and second abisip find?


Line 156: class AbisIpFind(log.Origin):
could be useful for other bts, e.g. the nano3G also responds to abisip-find. So 
might make sense as a separate .py file.


-- 
To view, visit https://gerrit.osmocom.org/7168
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
Gerrit-PatchSet: 4
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to