Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/7278/1/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: Line 1552: msc_subscr_conn_close(trans->conn, GSM_CAUSE_NET_FAIL); I'm not convinced. There can be any number of transactions in parallel, such as multiple voice calls (on hold) and/or SMSs. Only when the last transaction releases, we can close the SCCP connection. That's why we're freeing the transaction here and the responsibility is transferred to the transaction code. The question is why the trans_free is not sufficient here? -- To view, visit https://gerrit.osmocom.org/7278 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb00c889e7ce757aa93abc81418caf9e48d0908d Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
