Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/7316/1/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:

Line 330:       var hexstring aa_plmn := aa.routingAreaIdentification.mccDigit1
might make sense to put this into a function, to convert ericsson-style 'one 
record field per nibble' to the hexstring notation that we use in omsocom 
types?  Also, therem might be some overlap to f_RAI() in L3_Common.ttcn?


-- 
To view, visit https://gerrit.osmocom.org/7316
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8901ec0b090e342ebb04a04f9d759fc46c7d9cab
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to