Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/7333/3/src/libbsc/pcu_sock.c
File src/libbsc/pcu_sock.c:

Line 406:               tlli = osmo_load32be(data_req->data);
actually, I think it's not correct. Sorry for the suggestion. I only now see 
the context, and the PCU socket is using host byte order, not network byte 
order.


-- 
To view, visit https://gerrit.osmocom.org/7333
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c93487c72d15b061e73ed4f9acbf2e77dec967a
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to