Patch Set 4: Code-Review+1 (1 comment)
I'd +2 but let's give others a chance to comment https://gerrit.osmocom.org/#/c/7601/4/regen-makefile.sh File regen-makefile.sh: Line 51: if [ -n "$USE_CCACHE" ]; then (if I set my env to 'USE_CCACHE=0' then this still evaluates true. slightly nicer would be 'if [ "x$USE_CCACHE" = "x1" ]') -- To view, visit https://gerrit.osmocom.org/7601 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb538f602206535c06980f88191c1dabe3c4cd82 Gerrit-PatchSet: 4 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-HasComments: Yes
