Vadim Yanitskiy has submitted this change and it was merged.

Change subject: gsm0480: document the 'ss_request' structure
......................................................................


gsm0480: document the 'ss_request' structure

Change-Id: I22144dd759e0c1bb1965574b7ddd676606e5d6b7
---
M include/osmocom/gsm/gsm0480.h
1 file changed, 31 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h
index 0dfd868..05c26df 100644
--- a/include/osmocom/gsm/gsm0480.h
+++ b/include/osmocom/gsm/gsm0480.h
@@ -40,11 +40,42 @@
 int gsm0480_decode_ussd_request(const struct gsm48_hdr *hdr, uint16_t len,
                                struct ussd_request *request) 
OSMO_DEPRECATED("Use gsm0480_decode_ss_request() instead");
 
+/**
+ * This structure represents some meaningful parts of
+ * a decoded and/or to be encoded GSM 04.80 message.
+ */
 struct ss_request {
+       /**
+        * GSM TS 04.80, section 3.6.4 "Operation code"
+        * See GSM0480_OP_CODE_* for possible values.
+        */
        uint8_t opcode;
+       /**
+        * GSM TS 04.80, section 4.4.3.9 "ss-Code"
+        * The ss-Code identifier refers to the code which identify
+        * a supplementary service or a group of supplementary services.
+        */
        uint8_t ss_code;
+
+       /**
+        * A rudiment of deprecated 'ussd_request' structure.
+        * Represents the data of either an INVOKE, either
+        * a RETURN_RESULT component, encoded as ASCII in
+        * case if DCS is 0x0f (i.e. decoded by the code
+        * itself), otherwise raw bytes 'as is'.
+        */
        uint8_t ussd_text[GSM0480_USSD_OCTET_STRING_LEN];
+
+       /**
+        * GSM TS 04.80, section 3.3 "Transaction identifier"
+        * See GSM TS 04.07, section 11.2.3 for details.
+        */
        uint8_t transaction_id;
+       /**
+        * GSM TS 04.80, section 3.6.3 "Component ID tag"
+        * The term Component ID refers to the Invoke ID or
+        * the Linked ID.
+        */
        uint8_t invoke_id;
 };
 

-- 
To view, visit https://gerrit.osmocom.org/7624
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22144dd759e0c1bb1965574b7ddd676606e5d6b7
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>

Reply via email to