Review at  https://gerrit.osmocom.org/7668

host/trxcon: don't free root talloc context

This is useless, and prevents us from finding potential memory
leaks at exit. Let's print talloc report instead of that.

Change-Id: Ibf04942070d654e97c3ed77d69ab19e44602758c
---
M src/host/trxcon/trxcon.c
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/68/7668/1

diff --git a/src/host/trxcon/trxcon.c b/src/host/trxcon/trxcon.c
index 43c98a5..1d0ecc3 100644
--- a/src/host/trxcon/trxcon.c
+++ b/src/host/trxcon/trxcon.c
@@ -309,9 +309,14 @@
        /* Shutdown main state machine */
        osmo_fsm_inst_free(trxcon_fsm);
 
-       /* Make Valgrind happy */
+       /* Deinitialize logging */
        log_fini();
-       talloc_free(tall_trx_ctx);
+
+       /**
+        * Print report for the root talloc context in order
+        * to be able to find and fix potential memory leaks.
+        */
+       talloc_report_full(tall_trx_ctx, stderr);
 
        return rc;
 }

-- 
To view, visit https://gerrit.osmocom.org/7668
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf04942070d654e97c3ed77d69ab19e44602758c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>

Reply via email to