Patch Set 1: > About indenting style, personally I don't like this style. [..]
Everyone of course has their own preference, and everyone is entitled to have that. However, in any software project it is generally good if there is a common style to be followed by all the code, as it enhances readability across the project. It doesn't really matter which style it is, just as long as everyone is following it. In Osmocom, we indent additional argument to the point behind the opening parenthesis. So I would like to ask you to follow that, thanks! -- To view, visit https://gerrit.osmocom.org/7674 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4248ebf8626d3f7f0bf273fd20cc4f64e979938b Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: No