Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/7685/1/src/hlr.c
File src/hlr.c:

Line 49: /* Trigger 'Insert Subscriber Data' messages to all connected GSUP 
clients.
to all GSUP clients is ok for now, as we only expect a single MSC+SGSN to be 
connected.  However, in larger scale networks we should check to update only 
those MSC/SGSN which are listed in the subscriber data as the "current serving 
VLR/SGSN" for that subscriber.  I believe we already have those fields in our 
database model, not sure if they're already populated though.   In any case, we 
should at least have a a FIXME here to keep remembering something must be done 
in the future to avoid ISD into VLRs/SGSNs that are not even serving the 
subscriber.  At that point, the respective "vlr_subscriber" would be 
allocated/created in them, despite the subscriber not existing.


-- 
To view, visit https://gerrit.osmocom.org/7685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffe1d7afb9fc7dbae542f70bbf5391ddc08a14b4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to