Patch Set 1: (3 comments)
https://gerrit.osmocom.org/#/c/7677/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: Line 1384: static struct cmd_node ussd_node = { > How much USSD config will follow? Does it really warrant a new sub-node? My initial idea was to also add GSUP related configuration here. I was going to init a separate GSUP client and use it to connect to the external USSD handler (GSUP server). Now I understood that this is stupid idea, and I can reuse the existing link between both MSC and HLR... Not MSC should connect to a USSD gateway, but the gateway itself should connect to HLR. So, probably, we can avoid having a separate node. Line 1414: else { > the vty does pretty tight input checking, you will *never* get any other st Ok, thanks for a tip! I'll drop this branch. https://gerrit.osmocom.org/#/c/7677/1/src/osmo-msc/msc_main.c File src/osmo-msc/msc_main.c: Line 634: /* Initialize USSD */ > ("init_ussd" pretty much says it all, right?) Probably, it's my bad habit to comment each code block... -- To view, visit https://gerrit.osmocom.org/7677 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b3c5ccea4054113e8e23109b1ab68d9f0e18497 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
