Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/7677/1/src/osmo-msc/msc_main.c
File src/osmo-msc/msc_main.c:

Line 634:       /* Initialize USSD */
> Probably, it's my bad habit to comment each code block...
it's in many computer science syllabi as well: "comment every code block! even 
if it exactly copies the words of the code itself!" -- also happens with API 
docs a lot:  "get_frblxztrf(): Get the Frblxztrf." -- useless clutter :)


-- 
To view, visit https://gerrit.osmocom.org/7677
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b3c5ccea4054113e8e23109b1ab68d9f0e18497
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to