Patch Set 1: Code-Review+1

(2 comments)

LGTM. Some nitpicks.

https://gerrit.osmocom.org/#/c/7655/1/scripts/docker-cleanup.sh
File scripts/docker-cleanup.sh:

PS1, Line 4: `
nitpicks: shellcheck says:
- $() instead of ``. `` are legacy
- \^osmocom-build could be replaced with ^osmocom-build


PS1, Line 6: $f
shellcheck: use "$f" instead.


-- 
To view, visit https://gerrit.osmocom.org/7655
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I688b952578507a9cc28fe682221b5c7e3a245519
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-HasComments: Yes

Reply via email to