Patch Set 1:

File src/libbsc/bsc_vty.c:

Line 1918:              acc_ramp_init(&bts->acc_ramp, bts);
> I agree.
It can be left for a later patch, no problem.

Line 3278:      acc_ramp_enable(&bts->acc_ramp);
> I don't understand what this would achieve. The 'enable' flag does not chan
Indeed you are right, no issue here. I was mixing it with previous version 
which may have had some related issues.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia25bff85d9e5c277da76bffa11d31972e9fdc323
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <>
Gerrit-Reviewer: Stefan Sperling <>
Gerrit-HasComments: Yes

Reply via email to