Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/7752/1/mask_expected_results.sh
File mask_expected_results.sh:

Line 5:   sed -i "s/time='[^']*'/time='MASKED'/g" "$target"
> does the "MASKED" still constitute valid Juni2-XML? Is there a DTD availabl
not sure if the timestamp number within the quotes is in fact validated by a 
DTD; But also this expected-results.xml will never end up being parsed in 
jenkins or anything other than compare-results.sh. Jenkins will still always 
see the exact test case's junit results with timestamps and line numbers.


-- 
To view, visit https://gerrit.osmocom.org/7752
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I785e126b1f5afddd1b722bc5e922ed90970efa8a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to