Patch Set 1:

> I think the main problem here is that you're missing the L1 header

It's a problem of the current master. If you apply this
change, it should work, but there are some disadvantages
of this approach:

  - Both actual Timing Advance and MS Power level are used,
    while the higher layers may send Measurement Reports
    with spoofed value.

  - The Measurement Reports coming from the higher layers
    may contain neighbour measurements, while the messages
    being sent by trxcon (see sched_prim_sacch()) doesn't.

So, what I am going to do is to store a last Measurement
Report somewhere, and transmit it until a new one is arrived
from the higher layers.

Probably, some parts of the Measurement Reporting implementation
should be moved to L1, i.e. to the firmware, trxcon and VIRT-PHY.
This way each Measurement Report would always contain the actual
measurement results at the moment of transmission...

-- 
To view, visit https://gerrit.osmocom.org/7470
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-HasComments: No

Reply via email to